Programming

17423 readers

42 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 1 year ago

MODERATORS

snowe@programming.dev

Ategon@programming.dev

MaungaHikoi@lemmy.nz

How to conduct an effective code review (optimizedbyotto.com)

submitted 9 months ago by otto@programming.dev to c/programming@programming.dev

10 comments fedilink hide all child comments

Whether you're steering an open source project or leading full-time a software development team, the key to maximizing productivity lies in efficient code reviews.

you are viewing a single comment's thread
view the rest of the comments

[–] Kissaki@programming.dev 1 points 8 months ago

Interesting take I can't agree with. Maybe their product environment is very different.

once the feature finally arrives in production after a lengthy review, it is in truth no longer aligned with the user’s needs.

I've never had this happen in my development.

In my team, it's fine to skip reviews and commit on main, when it's reasonably small and confidence is high. An obvious and small change also does not take up much time to review.

The effort put into creating a well-/reasonably-described review is effort put into well design changesets and Git history. It helps you cover all bases, cases, and considerations while developing.

Review necessity, investment, and urgency are dynamic. If you as a reviewer don't have the time of mindspace, saying so is fine. Reviewers can be changed or skipped. Reviews can be to different depth and completeness, or partial.

Be mindful of what is reasonable and efficient and reviews are not hard blockers beyond what they should reasonably be. Reviews serve as significant quality, issue, and common understanding gates.