this post was submitted on 26 Oct 2023
917 points (96.5% liked)

Programmer Humor

19557 readers
381 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
917
When someone corrects your code (feddit.de)
submitted 1 year ago by genfood@feddit.de to c/programmer_humor@programming.dev
74 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[โ€“] little_hermit@lemmus.org 6 points 1 year ago (1 children)

Strange, I get a mild hostility vibe from colleagues if I review too ambitiously.

[โ€“] jadero@programming.dev 2 points 1 year ago

Reviews have to be balanced to circumstance. There is a big difference between putting out the sales brochure and the notice on the bulletin board. Likewise in coding a cryptographic framework for general consumption and that little script to create personal slideshows based on how you've tagged your photos.

As a general rule, wider distributions, public distributions, and long-lived distributions need more ambitious reviews. If the distribution is wide, public, and permanent, then everything needs very detailed scrutiny.

I have found some success in starting with and occasionally revisiting review goals. This helps create and maintain some consistency in a process that is scaled to the task at hand.