Either is fine: the question is what happens when something breaks and if you care about issues and such.
If your docker host depends on the pihole it's running, there can be some weirditry if it's not available during boot and whatnot (or if it crashes, etc.).
...I ended up with a docker container of pihole and an actual pi as the secondary so that it's nice and redundant.